feat: adds new snippet region tag for Desktop Windowing#834
feat: adds new snippet region tag for Desktop Windowing#834prateekbatra-g wants to merge 2 commits intomainfrom
Conversation
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new code snippet to showcase the implementation of a custom caption bar within the context of Compose Desktop Windowing. The primary goal is to provide a clear, self-contained example for developers looking to customize window decorations, specifically the title bar, in their Compose desktop applications. This enhances the available documentation and examples for adaptive layouts. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a new code snippet for creating a custom caption bar in a desktop Compose application. The implementation has a critical issue where the background colors for light and dark themes are inverted, leading to unreadable text due to poor contrast. I've provided a suggestion to fix this and also recommended using theme-based colors for better maintainability and consistency with Material Design, instead of hardcoded colors.
| if (isSystemInDarkTheme()) | ||
| Color.White | ||
| else Color.Black |
There was a problem hiding this comment.
The background color logic for dark and light themes is inverted, which will cause the text to be unreadable due to poor contrast. In dark mode, this sets a white background while the text color from the theme is likely light, making it illegible. A similar issue occurs in light theme with a black background and dark text.
While swapping Color.White and Color.Black would fix the immediate issue, a better long-term solution is to use colors from your MaterialTheme. Since you're already using MaterialTheme.typography, using theme colors for the background will make your component more robust and adaptable.
Here's a suggestion that fixes the inversion. For a more robust solution, consider refactoring to use theme colors like MaterialTheme.colorScheme.surfaceVariant for the background and onSurfaceVariant for the text.
| if (isSystemInDarkTheme()) | |
| Color.White | |
| else Color.Black | |
| if (isSystemInDarkTheme()) | |
| Color.Black | |
| else Color.White |
1 participant
feat: adds new snippet region tag for Desktop Windowing